[Webkit-unassigned] [Bug 14868] Import variable lookup optimizations from KJS
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 14 04:30:23 PDT 2007
http://bugs.webkit.org/show_bug.cgi?id=14868
cwzwarich at uwaterloo.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #15815|0 |1
is obsolete| |
Attachment #15958| |review?
Flag| |
------- Comment #3 from cwzwarich at uwaterloo.ca 2007-08-14 04:30 PDT -------
Created an attachment (id=15958)
--> (http://bugs.webkit.org/attachment.cgi?id=15958&action=view)
Revised proposed patch
(In reply to comment #2)
> (From update of attachment 15815 [edit])
> Need an extra space for indenting the comment at
> + if (!body->builtSymbolList()) {
> + // now handle other locals (functions, variables)
> + body->processDecls(&newExec);
Fixed.
> I'm less keen on + //### Document this, ugh.
I removed it. The same line it is commenting is without comment in the current
WebKit tree.
> function.h should also probably have you copyright info now
Done.
> ActivationImp
> putLocal -> replace assert with ASSERT
Fixed.
> putLocalChecked -> return on a new line
Fixed.
> isLocalReadOnly -> i'm not sure but i believe VS will want
> !!(_locals[propertyID].attr & ReadOnly)
Fixed.
> VarAccessNode
> optimizeLocalAccess -> no braces for "} else {" (and the closing '}')
Fixed. I also made it so there are no lone returns inside of else if and else
blocks.
> NonLocalVarAccessNode
> evaluateReference -> s/assert/ASSERT/
Fixed.
> nodes.h should possibly gain your copyright
Done.
> there are quite a few other places where assert is used instead of ASSERT
I changed them all.
> There are quite a few portions of this patch that look fairly trivial to make
> independent of this major patch -- for instance the [int] optimisation seems
> completely distinct from the improved scope lookup
Can you be more specific?
--
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list