[Webkit-unassigned] [Bug 14112] Cross-port KDE KJS UnaryPlus and UnaryMinus optimizations

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14112





------- Comment #9 from cwzwarich at uwaterloo.ca  2007-08-11 15:49 PDT -------
(In reply to comment #7)
> (From update of attachment 15864 [edit])
> This doesn't seem like an important optimization. How often does this happen in
> practice? Also, it seems like it breaks serialization of functions.

I'll remove the UnaryPlusNode optimization and keep the NegateNode one instead
of adding a fix for this.

> +    if (n->isNumber())
> +        return n;
> +    else
> +        return new UnaryPlusNode(n);
> 
> We normally don't do else after return.

Noted.

> The whitespace in the code above doesn't match our usual idiom. For example it
> should be this.
> 
>         NumberNode* number = static_cast<NumberNode*>(n);
> 
> Also:
> 
> +    double value() const KJS_FAST_CALL { return val; }
> +    void setValue(double v) KJS_FAST_CALL { val = v; }
> 
> Do inline functions like these need KJS_FAST_CALL?

I don't know, but it is the current practice in nodes.h.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.