[Webkit-unassigned] [Bug 14740] Hierarchical layout tests and platform organization

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14740


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15925|review?                     |review+
               Flag|                            |




------- Comment #14 from aroben at apple.com  2007-08-10 23:33 PDT -------
(From update of attachment 15925)
+    # FIXME: Get rid of the $useWinSkipped hack once Windows doesn't need a
Skipped file anymore
+    # or stops using the mac result directory or we come up with something
better.

I think this should say something clearer like:

# FIXME: The two lines below are a hack to represent that on Windows we
# currently want to
# 1) use the Mac expected results
# 2) use the Windows Skipped file
# Once Windows has its own results and/or we come up with a better way of
# sharing results with Mac, we should set $platform to "win" and get rid of
# $useWinSkipped entirely.

+            print "new (result generated in $expectedDir)\n";

I think it should be "results" with an "s".

+    if (!defined($platform) || $platform eq "none") {
+        return $testDirectory;
+    }

I think you'd better return ($testDirectory) so that the caller still gets a
list.

r=me


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.