[Webkit-unassigned] [Bug 14740] Hierarchical layout tests and platform organization

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 10 19:18:42 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=14740


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15915|review?                     |review+
               Flag|                            |




------- Comment #11 from aroben at apple.com  2007-08-10 19:18 PDT -------
(From update of attachment 15915)
+my $platformDefault = $platform ? $platform : "none";

I wonder if we should die if $platform is undefined at this point. Seems like
bad things might happen down the road if we keep going.

+        my $resultDir = expectedDirectoryForTest($test);

I think you can just use $expectedDir instead (this happens in 2 places).

r=me!


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list