[Webkit-unassigned] [Bug 14740] Hierarchical layout tests and platform organization

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 9 19:53:15 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=14740





------- Comment #9 from aroben at apple.com  2007-08-09 19:53 PDT -------
(From update of attachment 15892)
I just realized that platformDirForTest shouldn't be needed at all. It can all
be encapsulated into expectedDirectoryForTest, like so:

 sub expectedDirectoryForTest($)
 {
     my ($base) = @_;

    foreach my $level (@platformHierarchy) {
        return $level if (-f "$level/$base-$expectedTag.txt");
    }

    return $expectedDirectory if -f
"$expectedDirectory/$base-$expectedTag.txt";

    return $platformHierarchy[$#platformHierarchy];
 }

This should work correctly for both new and old tests, and for both generating
and comparing results.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list