[Webkit-unassigned] [Bug 13422] REGRESSION: Page reload loses page position

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 6 01:10:55 PDT 2007


cwzwarich at uwaterloo.ca changed:

           What    |Removed                     |Added
  Attachment #15846|                            |review?
               Flag|                            |

------- Comment #7 from cwzwarich at uwaterloo.ca  2007-08-06 01:10 PDT -------
Created an attachment (id=15846)
 --> (http://bugs.webkit.org/attachment.cgi?id=15846&action=view)
Proposed patch

Here is a patch that fixes the bug. In revision 17365, many Objective C method
bodies in WebFrame were moved to the C++ wrapper class WebFrameLoaderClient for
performance reasons. However, in copying the updateHistoryForReload() method, a
small error was introduced. In the original method, currItem is made the
current history item of the frame:

WebHistoryItem *currItem = _private->currentItem;

In the copied version, this is changed to

WebHistoryItem *currItem = m_webFrame->_private->previousItem;

This patch corrects that change, which was carried over into the new loader

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list