[Webkit-unassigned] [Bug 14745] WebKitTools/Scripts/run-launcher doesn't speak --gdk

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14745





------- Comment #13 from ddkilzer at webkit.org  2007-08-02 09:52 PDT -------
(In reply to comment #10)
> On second thoughts, I think that the better place to fix this (the --gdk flag
> being passed to GdkLauncher and subsequently interpreted as a URL) is in
> WebKitTools/GdkLauncher/main.cpp rather than in
> WebKitTools/Scripts/run-launcher.  You could patch run-launcher to explicitly
> scrub the --gdk argument, but you would miss any other flags that run-launcher
> takes (or could take, in the future), and GdkLauncher would (incorrectly) try
> to interpret them as a URL.

Sorry for the late reply, Nigel.

I agree with Adam's comments in Comment #12 that Perl should remove the
argument before calling gdklauncher.

In my opinion, gdklauncher should be using getopt() (or similar) routine for
parsing command-line switches instead of using custom code.  Then you have much
more robust command-line switch parsing, and you can decide whether to ignore
errors or report them.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.