[Webkit-unassigned] [Bug 14771] Mostly reproducible crash in modified celtickane benchmark

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14771


mrowe at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15724|review?                     |review-
               Flag|                            |




------- Comment #7 from mrowe at apple.com  2007-08-01 20:56 PDT -------
(From update of attachment 15724)
I'm going to mark this r-.  I spoke with Maciej on IRC about the general
approach this patch takes, and he said:

07:04 <othermaciej> bdash: upon further thought - I think the right rule should
be "don't use shared substring append on a string that is only a small part of
its current buffer"
07:04 <oothermaciej> bdash: I think the patch might actually implement
something close to that (it looks at post-append length though)

It should be simple to adjust the patch to this slightly different strategy. 
It would also be a good idea to see if we can't come up with some decent
criteria for "small part of its current buffer" that's not just picking a magic
number out of thin air :-)

My other concern is that "10 * length" looks like we're asking for overflow to
happen when dealing with large strings.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.