[Webkit-unassigned] [Bug 14824] REGRESSION(r14258): +setMIMETypesShownAsHTML has no effect if MIME type is text/* (works in Safari 2, doesn't work in Safari 3)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 1 17:19:58 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=14824





------- Comment #8 from beidson at apple.com  2007-08-01 17:19 PDT -------
It turns out the logic *is* all in WebCore - WebKitMac just takes an extremely
round about way of arriving at that.

I had a patch almost complete before the simple fix fell apart.  There's a big
problem here.

WebCore::MIMETypeRegistry has the concept of "supportedNonImageMIMETypes" and
all of those are considered to be "as HTML".  This set of mime types is what
WebKit ends up using when managing this API.

But then FrameLoader and/or DOMImplementation makes certain hard coded
decisions without calling to the MIMETypeRegistry.  Mark already pointed this
out.

This includes assuming that any "text/*" type besides "text/html" should
display as text.  That decision overrides the "as-html" registration.

I think theres a few fixes that can be made here.
1 - "cosmetically", collapse all the roundaboutness WebKitMac uses to connect
the API concept to the MIMETypeRegistry
2 - Find a clean way to move the concept of "text/* should be text" from hard
coded DOMImplementation logic into the MIMETypeRegistry. 

There's a few details that make this kind of complex - namely the fact that
"text/plain" and "text/" are in this hard coded list that are considered "HTML"
mimetypes by the WebKit API, but are hard coded to be considered text mime
types by WebCore.

=/


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list