[Webkit-unassigned] [Bug 12501] SVG Text fails to respect opacity, fill-opacity and stroke-opacity

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 30 17:43:32 PDT 2007


oliver at apple.com changed:

           What    |Removed                     |Added
  Attachment #14274|review?                     |review+
               Flag|                            |

------- Comment #2 from oliver at apple.com  2007-04-30 17:43 PDT -------
(From update of attachment 14274)
I'd almost prefer a declaration

CGFloat opacity = style->svgStyle()->strokeOpacity();
colorComponents[3] = opacity;
Color(float(colorComponents[0]) * 255., float(colorComponents[1]) * 255.,
float(colorComponents[2]) * 255., float(opacity) * 255.0f)

I think it makes it more clear that you're deliberately ignoring the alpha
channel specified by the style.

Also you have float(colorComponents[3] * 255.) which should be
float(colorComponents[3]) * 255. to match the other cases

255. should be 255.0f to prevent any dumb usages of double

otherwise r=me

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list