[Webkit-unassigned] [Bug 11588] tables misrender because WebKit lacks support for 'cols' attribute

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=11588





------- Comment #28 from oliver at apple.com  2007-04-27 23:55 PDT -------
(From update of attachment 13713)
Trivial issues:
* Refer to the bug number/url in the changelogs -- it makes it easier for us
when hunting regressions
* In the main changelog of your patch (WebCore/ChangeLog) put a brief
description of what the patch does -- look at other entries to get some idea of
what we expect
* Check for "\ No newline at end of file" in your patch, and add the final new
lines to the appropriate files -- your layout test source in this case
* you frequently have "}else..." -- there should be a space between } and else,
"} else.."


A few things of note:
* HTMLTableElement::attach
I would probably write something along the lines of 
if (renderer() && renderer()->isTable()) {
    RenderTable* table = static_cast<RenderTable*>(renderer());
    table->setCellPadding(m_padding);
    table->setCols(m_cols);
}

* HTMLTableElement.h
Define m_cols with the other locals.  Eg. before the friend class
HTMLTableCellElement; declaration

* Random comment
I'm not entirely comfortable with the replication of m_nCols/m_cols in
RenderTable and HTMLTableElement -- but it's been so long since i've worked
anywhere near so i can't remember how necessary it is/is not.

Unfortunately as i just said i'm nowhere near qualified here to do the logic
review for the real layout code in this patch -- that' probably best left to
hyatt


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.