[Webkit-unassigned] [Bug 13478] RenderObject::absoluteBoundingBoxRect() should ignore rects outside the bounds of the document

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13478


hyatt at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14219|review?                     |review-
               Flag|                            |




------- Comment #10 from hyatt at apple.com  2007-04-26 23:26 PDT -------
(From update of attachment 14219)
So you have really opened up a can of worms with this patch.

I don't think this is the right spot to deal with this problem looking into
this more.  There are several other callers of absoluteRects, and they are all
wrong too.

absoluteRects shouldn't even be handing back these unreachable rects in the
first place, so patching in absoluteBoundingBoxRect is dealing with the problem
too late.

WebCoreAXObject.mm calls absoluteRects for example (and so suffers from the
same bug), and HTMLAnchorElement.cpp does as well.

I think you basically need to patch absoluteRects to intersect the rects with
the document bounds.  There is no logical reason to ever be handing these
completely unreachable rects back.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.