[Webkit-unassigned] [Bug 13505] loses precision on x86_64

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 26 11:56:39 PDT 2007


------- Comment #2 from alp at atoker.com  2007-04-26 11:56 PDT -------
A few thoughts.

You should remove the comment about storing the opacity value directly now that
this isn't the case.

The ASSERT(opacity >= 0 && opacity <= 1) checks are no longer relevant either.

Also, we try to use C++ style casts rather than C style.

I think you can do direct assignment and leave casting to void* until later,
avoiding the memcpy (which has mis-formatted whitespace in your patch).

The final patch will need a ChangeLog entry -- see the 'prepare-ChangeLog'


Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list