[Webkit-unassigned] [Bug 13312] portable implementation of <canvas> element

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13312


bdash at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13993|                            |review-
               Flag|                            |




------- Comment #5 from bdash at webkit.org  2007-04-25 05:40 PDT -------
(From update of attachment 13993)
The big issue here is the addition of many new methods to GraphicsContext with
no implementations.  This will break all non-CoreGraphics builds, and at the
very least these should be stubbed out.  A ChangeLog entry and the necessary
project file changes would also be great.

Besides that there are some minor code style issues I noticed while skimming
the patch: the local variable "pg" in CanvasGradient::platformGradient seems
unnecessary and the placement of braces is incorrect, the declaration of
"count" has been manually lined up with "data", one of the changes in
HTMLCanvasElement.cpp adds unnecessary braces.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.