[Webkit-unassigned] [Bug 13420] New: Assert in addToTextEncodingNameMap() should use strcmp()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 20 15:22:05 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=13420

           Summary: Assert in addToTextEncodingNameMap() should use strcmp()
           Product: WebKit
           Version: 522+ (nightly)
          Platform: PC
        OS/Version: Windows XP
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: pkasting at google.com


TextEncodingRegistry.cpp:addToTextEncodingNameMap() has the following code:

ASSERT(alias == name || atomicName);

...where alias and name are both char*s.

We need to use strcmp() here, because the pointers are not guaranteed to be the
same.  (Other similar statements elsewhere are safe, because they deal with the
returned pointers out of the hash map.)

Patch coming shortly.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list