[Webkit-unassigned] [Bug 13407] [GDK] Fix font support in Gdk port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 20 00:07:40 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=13407


bdash at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14092|review?                     |review+
               Flag|                            |




------- Comment #2 from bdash at webkit.org  2007-04-20 00:07 PDT -------
(From update of attachment 14092)
Keep in mind that we prefer C++-style casts over the C-style casts.  It looks
like the "assert" on "pattern" will only detect an out-of-memory condition,
which is a runtime error and as such not appropriate for an assertion.

r=me, I'll address those two nits when I land the change.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list