[Webkit-unassigned] [Bug 13398] [GDK] Bring the port up to date

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 18 14:05:07 PDT 2007


sam at webkit.org changed:

           What    |Removed                     |Added
  Attachment #14080|review?                     |review+
               Flag|                            |

------- Comment #2 from sam at webkit.org  2007-04-18 14:05 PDT -------
(From update of attachment 14080)
This seems fine except for 2 nit picks.  First, there are a couple tabs in the
ChangeLog that should be removed before landing.  Second, there should be a
space after the "return 0;" here:

+WebCore::Page* ChromeClientGdk::createModalDialog(Frame*, const
FrameLoadRequest&) { notImplementedGdk(); return 0;}

Otherwise, r=me.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list