[Webkit-unassigned] [Bug 13344] pdf file is getting opened in a new window using adobe plugin

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 13 21:05:57 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=13344





------- Comment #4 from darin at apple.com  2007-04-13 21:05 PDT -------
(From update of attachment 14032)
Here are some nitpicks:

Need spaces after commas in function calls.

> </HTML>
> \ No newline at end of file

Should have a newline at the end of the file.

> +<HTML>
> <HEAD>
> <H3> The PDF file should be opened in the same window of the browser using adobe plug-in</H3>
> <OBJECT id="PDFObject" height="500" width="100%" type="Application/pdf" data="testqueue.pdf"></OBJECT>
> </HEAD>
> </HTML>

There are no pluses, which makes it look like this entire file is one big line
-- I think there's a CR/LF problem here.

+2007-04-13  Madhu  <madhu.mukund at wipro.com>
+
+        Reviewed by NOBODY (OOPS!).
+
+        * plugins/simple_pdf_test-expected.txt: Added.

Change log entry doesn't say what this test is about. Look at other
LayoutTests/ChangeLog entries to see what we usually do.

> +              if (!equalIgnoringCase(name,"type")) {
> +                 if (embed || !uniqueParamNames.contains(name.impl())) {

I think this change needs a comment. It's entirely unclear why the name "type"
is a special case.

The change log does explain things but a comment in the code is warranted in
this case.

The change log makes it sound like this change is "for the Adobe plug-in", but
it's not really specific to any Adobe requirement. It would be better to word
it in a way that makes it more clear.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list