[Webkit-unassigned] [Bug 13227] StringImpl::isLower incorrectly assumes islower returns 1 (it can return any non-0)

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13227





------- Comment #8 from darin at apple.com  2007-04-11 01:25 PDT -------
My bad. Looks like I was completely wrong!

And in fact, the more obvious "early exit" version that breaks the loop when it
finds something that's not lower is faster than any of the others in all cases
I tested.

The "all lowercase" test was flawed because spaces are not lowercase.

All lowercase:

Original: 2.225
Boolean: 2.455
Logical: 2.226
Early Exit: 2.088

No lowercase:

Original: 2.521
Boolean: 2.782
Logical: 1.066
Early Exit: 0.107


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.