[Webkit-unassigned] [Bug 13227] In StringImpl::isLower, '&' used with ints is not very kosher

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 5 14:14:26 PDT 2007


------- Comment #3 from KwhiteRight at gmail.com  2007-04-05 14:14 PDT -------
islower() from the C lib only claims to return nonzero if the character is
lower-case, not necessarily 1. If it happened to return 1 in some situation and
2 in some other, the current test would fail.

An alternative to 
  allLower &= islower(c & 0x7F) != 0;
would be
  allLower = allLower && islower(c & 0x7F);
if that's faster.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list