[Webkit-unassigned] [Bug 5262] XMLSerializer drops Namespace information

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 5 08:56:19 PDT 2007


darin at apple.com changed:

           What    |Removed                     |Added
  Attachment #13953|review?                     |review+
               Flag|                            |

------- Comment #21 from darin at apple.com  2007-04-05 08:56 PDT -------
(From update of attachment 13953)

There are three minor things wrong with this patch that are not serious enough
for a review-. One is that the change log for LayoutTests needs to list the
files modified, and in a couple cases instead it's listing the .xhtml files of
the tests with changed results.

Second, the explanation of nodeisequalnode14.xhtml failure is unnecessarily
confusing. It should say that it's supposed to create an Attr with localName of
null, which is the salient point I think.

The third problem is that we don't have nearly enough testing of the behavior
of createElementNS and getElementsByTagNameNS when passed a namespace of null
-- the new layout test is the only one that calls them that way, and it doesn't
test the behavior very thoroughly.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list