[Webkit-unassigned] [Bug 5262] XMLSerializer drops Namespace information

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=5262


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13938|review?                     |review-
               Flag|                            |




------- Comment #19 from darin at apple.com  2007-04-04 09:31 PDT -------
(From update of attachment 13938)
Patch basically looks pretty good.

+    // Test _namespaceURI for "null" as null from js comes through as "null"

That's a bug that should be fixed at JavaScript binding call site. We shouldn't
convert a null to a string and then check for "null". Instead we should use
[ConvertNullToNullString] in the Document.idl file. Look at
DOMImplementation.idl for examples.

-                        markups.prepend(startMarkup(parent, range, annotate));
+                        markups.prepend(startMarkup(parent, range, annotate,
false, 0));

-                        markups.prepend(startMarkup(parent, range, annotate));
+                        markups.prepend(startMarkup(parent, range, annotate,
false, 0));

-                markups.prepend(startMarkup(ancestor, range, annotate,
convertBlocksToInlines));
+                markups.prepend(startMarkup(ancestor, range, annotate,
convertBlocksToInlines, 0));

-                markups.prepend(startMarkup(ancestor, range, annotate));
+                markups.prepend(startMarkup(ancestor, range, annotate, false,
0));

Why are these helpful changes? Those are the default values of those
parameters.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.