[Webkit-unassigned] [Bug 13081] Empty table cells not handled correctly
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 3 09:16:10 PDT 2007
http://bugs.webkit.org/show_bug.cgi?id=13081
darin at apple.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #13933|review? |review+
Flag| |
------- Comment #6 from darin at apple.com 2007-04-03 09:16 PDT -------
(From update of attachment 13933)
+ if(!m_layoutStruct[lastCol].emptyCellsOnly)
Needs a space after the if.
case Static:
- numAuto++;
- totalAuto += m_layoutStruct[i].effMaxWidth;
- allocAuto += w;
+ if (m_layoutStruct[i].emptyCellsOnly)
+ numAutoEmptyCellsOnly++;
+ else {
+ numAuto++;
+ totalAuto += m_layoutStruct[i].effMaxWidth;
+ allocAuto += w;
+ }
default:
break;
It's pretty cheesy how this shares the break with the default case. I suggest
we remove the default altogether so we get the gcc warning about any missing
case values.
r=me
--
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list