[Webkit-unassigned] [Bug 11015] SVG handles em units incorrectly

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Wed Sep 27 03:40:49 PDT 2006


http://bugzilla.opendarwin.org/show_bug.cgi?id=11015


macdome at opendarwin.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10796|review?                     |review-
               Flag|                            |




------- Comment #5 from macdome at opendarwin.org  2006-09-27 03:40 PDT -------
(From update of attachment 10796)
Hum...  Did you test to see if each of these was needed?

     if (attr->name() == SVGNames::xAttr) {
         xBaseValue()->setValueAsString(value);
+        if (renderer())
+            renderer()->setNeedsLayout(true);

Also, that's the wrong place to put that.  Those invalidations should go in
attributeChange(attributeName) instead of parseMappedAttribute

Otherwise the patch looks great!


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list