[Webkit-unassigned] [Bug 10903] Yet Another Objective-C Bindings Patch

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=10903


timothy at hatcher.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10608|review?                     |review-
               Flag|                            |




------- Comment #2 from timothy at hatcher.name  2006-09-17 14:45 PDT -------
(From update of attachment 10608)
+#import <WebCore/DOMDOMImplementation.h>

THis was in the original order because once in WebKit is will be:

#import <WebCore/DOMImplementation.h>

So the order in WeCore is wrong but it will be right once in WebKit.

DOMObject.h needs to include DOMException.h since you removed the enum from
there.

isContentEditable should be for ObjC only. This naming schee is only common in
ObjC (with the "is" prefix for boolean types.) Other languages should just be
"bool contentEditible". I am fine keeping isContentEditable as a hand
implemented method.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.