[Webkit-unassigned] [Bug 6002] WebKit does not properly handle SVG <cursor> element

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=6002


macdome at opendarwin.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10574|review?                     |review-
               Flag|                            |




------- Comment #31 from macdome at opendarwin.org  2006-09-15 15:10 PDT -------
(From update of attachment 10574)
I'm still not a big fan of needing a separate class "CursorList" to hold all
the nodes, when the individual CursorData nodes could just form a singly linked
list and know how to delete their "next" pointer when they are themselves
deleted.

This would also remove the need for RenderStyle::addCursor...


+using namespace SVGNames;

needs to be inside a SVG_SUPPORT block in FrameView.cpp

Is there any need to check the type here?
+            value = valueList->next(); // comma

We'll need some more tests.

It's not clear to me how the CursorList is ever destroyed.

It's also not clear to me that two divs, one inside the other, both which use
independent cursor fallback will properly function (i.e. when is the cursors()
list cleared?)

I don't think we can land this without at least answering the leak question.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.