[Webkit-unassigned] [Bug 10813] REGRESSION (r16245): double-clicking on javascript exceptions fails to show source

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Thu Sep 14 12:54:23 PDT 2006


ap at nypop.com changed:

           What    |Removed                     |Added
  Attachment #10543|review?                     |review+
               Flag|                            |

------- Comment #4 from ap at nypop.com  2006-09-14 12:54 PDT -------
(From update of attachment 10543)
r=me (yes, even without a ChangeLog entry ;) )

I think that this patch properly fixes the regression, but the behavior is
still seriously broken. This code path is used when HTTP headers don't specify
an encoding, but there are numerous other ways for WebCore to pick one, and the
same encoding should be used for handling a resource and for providing it
source, obviously. 

+    NSString* name = textEncodingName ? textEncodingName : @"Latin-1";

We usually call this encoding "iso-8859-1". Might make sense to do so here for
consistency, as well.

Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list