[Webkit-unassigned] [Bug 10856] New: Fix for Build 16363

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=10856

           Summary: Fix for Build 16363
           Product: WebKit
           Version: 420+ (nightly)
          Platform: PC
        OS/Version: Windows XP
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at opendarwin.org
        ReportedBy: karthikkumar at gmail.com


Compilation breaks on Windows.. the following patch adds temporarylinkstubs and
fixes it.

Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog   (revision 16363)
+++ WebCore/ChangeLog   (working copy)
@@ -1,3 +1,10 @@
+2006-09-14  Karthik Kumar  <karthikkumar at gmail.com>
+
+        Wrote temporary link stubs to fix compilation on Windows.
+
+        * platform/win/TemporaryLinkStubs.cpp
+        * WebCore.vcproj/WebCore/WebCore.vcproj 
+
 2006-09-14  Brady Eidson  <beidson at apple.com>

         Part of a build fix for Windows - rest will be working out a mess of
temporary link stubs
Index: WebCore/WebCore.vcproj/WebCore/WebCore.vcproj
===================================================================
--- WebCore/WebCore.vcproj/WebCore/WebCore.vcproj       (revision 16363)
+++ WebCore/WebCore.vcproj/WebCore/WebCore.vcproj       (working copy)
@@ -41,7 +41,7 @@
                        <Tool
                                Name="VCCLCompilerTool"
                                Optimization="0"
-                              
AdditionalIncludeDirectories=""$(ProjectDir)\..\..\..\iconv\include";"$(ProjectDir)\..\..\..\icu\include";"$(ProjectDir)\..\..\..\libxml\include";"$(ProjectDir)\..\..\..\libxslt\include";"$(ProjectDir)\..\..\DerivedSources\WebCore";"$(ProjectDir)\..\..\";"$(ProjectDir)\..\..\css";"$(ProjectDir)\..\..\editing";"$(ProjectDir)\..\..\rendering";"$(ProjectDir)\..\..\bindings\js";"$(ProjectDir)\..\..\dom";"$(ProjectDir)\..\..\html";"$(ProjectDir)\..\..\bridge";"$(ProjectDir)\..\..\bridge\win";"$(ProjectDir)\..\..\loader";"$(ProjectDir)\..\..\page";"$(ProjectDir)\..\..\platform";"$(ProjectDir)\..\..\platform\cairo";"$(ProjectDir)\..\..\platform\image-decoders";"$(ProjectDir)\..\..\platform\image-decoders\bmp";"$(ProjectDir)\..\..\platform\image-decoders\gif";"$(ProjectDir)\..\..\platform\image-decoders\ico";"$(ProjectDir)\..\..\platform\image-decoders\jpeg";"$(ProjectDir)\..\..\platform\image-decoders\png";"$(ProjectDir)\..\..\platform\image-decoders\xbm";"$(ProjectDir)\..\..\platform\image-decoders\zlib";"$(ProjectDir)\..\..\xml";"$(ProjectDir)\..\..\..\JavaScriptCore";"$(ProjectDir)\..\..\..\JavaScriptCore\os-win32";"$(ProjectDir)\..\..\ForwardingHeaders";"$(WebKitOutputDir)\WebCore.intermediate\$(ConfigurationName)\WebCore.intermediate\DerivedSources";"$(ProjectDir)\..\..\..\JavaScriptCore\kjs";"$(ProjectDir)\..\..\platform\win";"$(ProjectDir)\..\..\platform\cairo\pixman\src";"$(ProjectDir)\..\..\platform\cairo\cairo\src""
+                              
AdditionalIncludeDirectories=""$(ProjectDir)\..\..\..\iconv\include";"$(ProjectDir)\..\..\..\icu\include";"$(ProjectDir)\..\..\..\libxml\include";"$(ProjectDir)\..\..\..\libxslt\include";"$(ProjectDir)\..\..\DerivedSources\WebCore";"$(ProjectDir)\..\..\";"$(ProjectDir)\..\..\css";"$(ProjectDir)\..\..\editing";"$(ProjectDir)\..\..\rendering";"$(ProjectDir)\..\..\bindings\js";"$(ProjectDir)\..\..\dom";"$(ProjectDir)\..\..\html";"$(ProjectDir)\..\..\bridge";"$(ProjectDir)\..\..\bridge\win";"$(ProjectDir)\..\..\loader";"$(ProjectDir)\..\..\page";"$(ProjectDir)\..\..\platform";"$(ProjectDir)\..\..\platform\cairo";"$(ProjectDir)\..\..\platform\image-decoders";"$(ProjectDir)\..\..\platform\image-decoders\bmp";"$(ProjectDir)\..\..\platform\image-decoders\gif";"$(ProjectDir)\..\..\platform\image-decoders\ico";"$(ProjectDir)\..\..\platform\image-decoders\jpeg";"$(ProjectDir)\..\..\platform\image-decoders\png";"$(ProjectDir)\..\..\platform\image-decoders\xbm";"$(ProjectDir)\..\..\platform\image-decoders\zlib";"$(ProjectDir)\..\..\xml";"$(ProjectDir)\..\..\..\JavaScriptCore";"$(ProjectDir)\..\..\..\JavaScriptCore\os-win32";"$(ProjectDir)\..\..\ForwardingHeaders";"$(WebKitOutputDir)\WebCore.intermediate\$(ConfigurationName)\WebCore.intermediate\DerivedSources";"$(ProjectDir)\..\..\..\JavaScriptCore\kjs";"$(ProjectDir)\..\..\platform\win";"$(ProjectDir)\..\..\platform\cairo\pixman\src";"$(ProjectDir)\..\..\platform\cairo\cairo\src";"$(ProjectDir)\..\..\loader\icon""
                               
PreprocessorDefinitions="WIN32;KHTML_NO_XBL;KHTML_XSLT;XPATH_SUPPORT"
                                MinimalRebuild="true"
                                ExceptionHandling="0"
@@ -108,7 +108,7 @@
                        />
                        <Tool
                                Name="VCCLCompilerTool"
-                              
AdditionalIncludeDirectories=""$(ProjectDir)\..\..\..\iconv\include";"$(ProjectDir)\..\..\..\icu\include";"$(ProjectDir)\..\..\..\libxml\include";"$(ProjectDir)\..\..\..\libxslt\include";"$(ProjectDir)\..\..\DerivedSources\WebCore";"$(ProjectDir)\..\..\";"$(ProjectDir)\..\..\css";"$(ProjectDir)\..\..\editing";"$(ProjectDir)\..\..\rendering";"$(ProjectDir)\..\..\bindings\js";"$(ProjectDir)\..\..\dom";"$(ProjectDir)\..\..\html";"$(ProjectDir)\..\..\bridge";"$(ProjectDir)\..\..\bridge\win";"$(ProjectDir)\..\..\loader";"$(ProjectDir)\..\..\page";"$(ProjectDir)\..\..\platform";"$(ProjectDir)\..\..\platform\cairo";"$(ProjectDir)\..\..\platform\image-decoders";"$(ProjectDir)\..\..\platform\image-decoders\bmp";"$(ProjectDir)\..\..\platform\image-decoders\gif";"$(ProjectDir)\..\..\platform\image-decoders\ico";"$(ProjectDir)\..\..\platform\image-decoders\jpeg";"$(ProjectDir)\..\..\platform\image-decoders\png";"$(ProjectDir)\..\..\platform\image-decoders\xbm";"$(ProjectDir)\..\..\platform\image-decoders\zlib";"$(ProjectDir)\..\..\xml";"$(ProjectDir)\..\..\..\JavaScriptCore";"$(ProjectDir)\..\..\..\JavaScriptCore\os-win32";"$(ProjectDir)\..\..\ForwardingHeaders";"$(WebKitOutputDir)\WebCore.intermediate\$(ConfigurationName)\WebCore.intermediate\DerivedSources";"$(ProjectDir)\..\..\..\JavaScriptCore\kjs";"$(ProjectDir)\..\..\platform\win";"$(ProjectDir)\..\..\platform\cairo\pixman\src";"$(ProjectDir)\..\..\platform\cairo\cairo\src""
+                              
AdditionalIncludeDirectories=""$(ProjectDir)\..\..\..\iconv\include";"$(ProjectDir)\..\..\..\icu\include";"$(ProjectDir)\..\..\..\libxml\include";"$(ProjectDir)\..\..\..\libxslt\include";"$(ProjectDir)\..\..\DerivedSources\WebCore";"$(ProjectDir)\..\..\";"$(ProjectDir)\..\..\css";"$(ProjectDir)\..\..\editing";"$(ProjectDir)\..\..\rendering";"$(ProjectDir)\..\..\bindings\js";"$(ProjectDir)\..\..\dom";"$(ProjectDir)\..\..\html";"$(ProjectDir)\..\..\bridge";"$(ProjectDir)\..\..\bridge\win";"$(ProjectDir)\..\..\loader";"$(ProjectDir)\..\..\page";"$(ProjectDir)\..\..\platform";"$(ProjectDir)\..\..\platform\cairo";"$(ProjectDir)\..\..\platform\image-decoders";"$(ProjectDir)\..\..\platform\image-decoders\bmp";"$(ProjectDir)\..\..\platform\image-decoders\gif";"$(ProjectDir)\..\..\platform\image-decoders\ico";"$(ProjectDir)\..\..\platform\image-decoders\jpeg";"$(ProjectDir)\..\..\platform\image-decoders\png";"$(ProjectDir)\..\..\platform\image-decoders\xbm";"$(ProjectDir)\..\..\platform\image-decoders\zlib";"$(ProjectDir)\..\..\xml";"$(ProjectDir)\..\..\..\JavaScriptCore";"$(ProjectDir)\..\..\..\JavaScriptCore\os-win32";"$(ProjectDir)\..\..\ForwardingHeaders";"$(WebKitOutputDir)\WebCore.intermediate\$(ConfigurationName)\WebCore.intermediate\DerivedSources";"$(ProjectDir)\..\..\..\JavaScriptCore\kjs";"$(ProjectDir)\..\..\platform\win";"$(ProjectDir)\..\..\platform\cairo\pixman\src";"$(ProjectDir)\..\..\platform\cairo\cairo\src";"$(ProjectDir)\..\..\loader\icon""
                               
PreprocessorDefinitions="WIN32;KHTML_NO_XBL;KHTML_XSLT;XPATH_SUPPORT;NDEBUG"
                                ExceptionHandling="0"
                                RuntimeLibrary="2"
Index: WebCore/platform/win/TemporaryLinkStubs.cpp
===================================================================
--- WebCore/platform/win/TemporaryLinkStubs.cpp (revision 16363)
+++ WebCore/platform/win/TemporaryLinkStubs.cpp (working copy)
@@ -65,6 +65,8 @@
 #include "RenderPopupMenuWin.h"
 #include "EditCommand.h"
 #include "Icon.h"
+#include "IconLoader.h"
+#include "IconDatabase.h"

 using namespace WebCore;

@@ -378,4 +380,12 @@ void RenderThemeWin::adjustMenuListStyle
 Icon::Icon() { notImplemented(); }
 Icon::~Icon() { notImplemented(); }
 PassRefPtr<Icon> Icon::newIconForFile(const String& filename) {
notImplemented(); return PassRefPtr<Icon>(new Icon()); }
-void Icon::paint(GraphicsContext*, const IntRect&) { notImplemented(); }
\ No newline at end of file
+void Icon::paint(GraphicsContext*, const IntRect&) { notImplemented(); }
+
+void IconLoader::stopLoading() { notImplemented(); } 
+void IconLoader::startLoading() { notImplemented(); } 
+IconLoader* IconLoader::createForFrame(Frame *frame) { return 0; } 
+
+bool IconDatabase::isIconExpiredForIconURL(const String& url) { return false;
}
+bool IconDatabase::hasEntryForIconURL(const String& url) { return false; }
+IconDatabase* IconDatabase::sharedIconDatabase() { return 0; }


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.