[Webkit-unassigned] [Bug 10845] Various bugs in ResourceLoaderWin with local files

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=10845





------- Comment #7 from morlmor at yahoo.com  2006-09-13 20:18 PDT -------
(In reply to comment #5)
> (From update of attachment 10546 [edit])
>  void ResourceLoader::fileLoadTimer(Timer<ResourceLoader>* timer)
>  {
> +    client()->receivedResponse(this, 0);
> 
> This seems to me to introduce incorrect behavior - client->receivedResponse()
> is only supposed to be called when the HTTP response comes back for a HTTP
> request.  If it's only data you're talking about, client->receivedData() is 
> all that needs to be called.

I see.  I figured that the consumer might be insulated from such details. 
Perhaps it would help if there was some documentation for the
ResourceLoaderClient.  Afterall, someone is very likely to write code that
assumes a receivedResponse occurs before the first receivedData, especially if
they only test with HTTP URLs.

I'll try to reproduce the crash and see if this is truly to blame.  I assumed
it was merely an oversight :-/


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.