[Webkit-unassigned] [Bug 10836] REGRESSION: Mac implementation of Font::drawGlyphs leaks a CGColorRef

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=10836


macdome at opendarwin.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10548|review?                     |review+
               Flag|                            |




------- Comment #2 from macdome at opendarwin.org  2006-09-13 15:49 PDT -------
(From update of attachment 10548)
My mistake, thanks for fixing.

You might add a:
 // WebCore expects text to respect the pen color, CG expects text to use fill

comment to the other place as well, I had meant to do that originally.

Also, this makes me wonder if it wouldn't be a better idea to set the color on
the context with 4 floats to prevent the malloc/free associated with creating a
color and freeing...  If it shows up in shark we'll have to move to that model.

r=me


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.