[Webkit-unassigned] [Bug 10834] New: FileChooser constructor in FileChooserMac appears to overretain m_controller

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=10834

           Summary: FileChooser constructor in FileChooserMac appears to
                    overretain m_controller
           Product: WebKit
           Version: 420+ (nightly)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Forms
        AssignedTo: webkit-unassigned at opendarwin.org
        ReportedBy: opendarwin.org at bdash.net.nz
                CC: aroben at apple.com


m_controller's initializer
(http://trac.webkit.org/projects/webkit/browser/trunk/WebCore/platform/mac/FileChooserMac.mm?rev=16323#L92)
reads:

    , m_controller([[[OpenPanelController alloc] initWithFileChooser:this]
retain])

Allocing and then retaining the OpenPanelController seems incorrect to me.  If
this is intended, it should have some form of explanatory comment as it's not
standard practice.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.