[Webkit-unassigned] [Bug 6002] WebKit does not properly handle SVG <cursor> element

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=6002





------- Comment #24 from darin at apple.com  2006-09-10 19:50 PDT -------
(In reply to comment #22)
> (In reply to comment #21)
> > +        if (!strict && value->id == CSS_VAL_HAND) { // MSIE 5 compatibility :/
> > +            id = CSS_VAL_POINTER;
> > +            valid_primitive = true;
> > +        } else if (value->id >= CSS_VAL_AUTO && value->id <= CSS_VAL_HELP)
> > 
> > How does the CSS_VAL_AUTO case here work? I don't see it setting id, and it
> > looks to me like code below in the if (valid_primitive) block isn't going to
> > work if id is not set.
> 
> The counter ids are only added at the end of the list, and I think the
> parsedValue is the block that should work (for the list) instead of
> valid_primitive block. Correct me if you think that is wong, but that
> is how I remember from the original patch.

I do think that's wrong. Look carefully at the part of the patch I'm quoting.
If we ever hit this code, then there is no list. Either that code is wrong and
unreachable (and should be deleted), or it's wrote and reachable (so we need a
test case), or I'm mistaken. But I think I'm reading this right.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.