[Webkit-unassigned] [Bug 10323] REGRESSION: javascript: URL containing '\\' gets passed as '//'

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=10323


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10478|review?                     |review-
               Flag|                            |




------- Comment #9 from darin at apple.com  2006-09-10 12:40 PDT -------
(From update of attachment 10478)
The code change is good, but I think this comment change is a bad idea:

-    // for compatibility with Win IE, we must treat backslashes as if they
were slashes
+    // temporary fix for proper backslash substitution

You've replaced a comment that mentions the Win IE compatibility issue with one
that is considerably more vague. The comment says this is "temporary" without
explaining what's temporary about it or when the temporary time would be over.
The comment says "proper backslash substitution" but there's no explanation for
why backslashes need to be substituted at all or what would be proper vs.
improper.

Patch is great otherwise, but review- for the comment.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.