[Webkit-unassigned] [Bug 6002] WebKit does not properly handle SVG <cursor> element

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=6002


macdome at opendarwin.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10483|review?                     |review-
               Flag|                            |




------- Comment #19 from macdome at opendarwin.org  2006-09-10 01:45 PDT -------
(From update of attachment 10483)
Storing a Vector on RenderStyle is not a good idea.  That uses at least 4 more
bytes than it needs to.  Storing a pointer to a vector would be OK, or using a
list, both would work (personally I'm partial to the list).

Creating a CSSValueList unconditionally, and then deleting it if not needed is
wasteful.

+        CSSValueList* list = new CSSValueList;

A better method is to have an if in your while statement which checks
if (!list)
    list = new CSSValueList;

Copy-paste error, you set the X value of the hotspot twice:
+                    hotspot.setX(value->fValue);

Also, you don't properly error out when it's
cursor: url("foo.png") 1, auto;
a single number should be an error.

I still would argue that a missing last value should only be allowed in quirks
mode:

+            if (!value) { // no value after url list (MSIE 5 compatibility)

+                       
style->addCursor(primitiveValue->getStringValue().deprecatedString().mid(1));

This doesn't need to use a deprecatedString.  .substring(1) will do the same as
.mid(1)

Otherwise it looks fine.
Need one more round on this.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.