[Webkit-unassigned] [Bug 10801] REGRESSION: Styled form controls lose their intrinsic margins

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=10801


hyatt at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-                     |hyatt at apple.com
                   |unassigned at opendarwin.org   |
             Status|NEW                         |ASSIGNED
  Attachment #10482|                            |review?
               Flag|                            |




------- Comment #1 from hyatt at apple.com  2006-09-09 23:44 PDT -------
Created an attachment (id=10482)
 --> (http://bugzilla.opendarwin.org/attachment.cgi?id=10482&action=view)
Rework intrinsic margin code

This patch reworks intrinsic margins and consolidates all the code in one
place.

Before this code was found in three places: old form controls, the themes for
engine controls, and the layer for ensuring resizers didn't cause jumpiness.

Now the intrinsic margin is adjusted in one place: adjustRenderStyle.  It's
done regardless of how the control is implemented (old, new, styled, unstyled,
etc.).

This means that some controls are no going to acquire intrinsic margins that
didn't before (I believe this is a good thing, since now all controls will be
consistent).  The biggest change will be the image button.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the assignee for the bug, or are watching the assignee.