[Webkit-unassigned] [Bug 10765] Windows build busted due to std::copy usage in Vector.h

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=10765


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10444|review?                     |review-
               Flag|                            |




------- Comment #4 from darin at apple.com  2006-09-08 09:41 PDT -------
(From update of attachment 10444)
I really like this approach.

But since std::copy is really just a while loop, there's no reason to change
the semantics and possibly the performance characteristics just to get rid of
std::copy.

We could just create a couple local variables and write the loop by hand to
avoid the warning. Or write our own equivalent of the std::function.

I suggest we consider changing to the uninitializedCopy approach on its own
merits rather than doing it as part of this change.

I'm going to mark this review- because of that issue, even though I really like
the direction of this fix.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.