[Webkit-unassigned] [Bug 10746] New: SVG code calls fooBaseValue() many times when it should call foo()

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Wed Sep 6 01:18:51 PDT 2006


http://bugzilla.opendarwin.org/show_bug.cgi?id=10746

           Summary: SVG code calls fooBaseValue() many times when it should
                    call foo()
           Product: WebKit
           Version: 420+ (nightly)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: normal
          Priority: P4
         Component: SVG
        AssignedTo: webkit-unassigned at opendarwin.org
        ReportedBy: macdome at opendarwin.org


SVG code calls fooBaseValue() many times when it should call foo()

Now that the old broken SVGAnimated* code is removed as part of bug 10490, it
has become obvious how many times the SVG code uses the wrong value (base vs.
anim) for its calculations.  Before base and anim values were actually stored
separately.  Now they are stored together until animation is enabled, at which
point their storage is separate, until the element stops animating again.

Someone needs to do a search for all uses of BaseValue() and make sure that
those callsites really need access to the baseVal instead of the animVal. 
There are basically only 3 sections of c++ code which should ever need access
to the baseValues.  Those are:
1.  attribute parsing code (always should use setFooBaseValue())
2.  animation code (may need to use fooBaseValue() to retrieve the base value
for animation-related calculations).
3.  SVG DOM bindings.  JSSVGAnimated* bindings will need to call fooBaseValue()
and setFooBaseValue()


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list