[Webkit-unassigned] [Bug 10729] New: Very short plain text documents have a wider top margin

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=10729

           Summary: Very short plain text documents have a wider top margin
           Product: WebKit
           Version: 420+ (nightly)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Page Loading
        AssignedTo: webkit-unassigned at opendarwin.org
        ReportedBy: opendarwin.org at mitzpettel.com
                CC: ap at nypop.com


The decoder changes in r16175 caused fast/text/plain-text-line-breaks.html to
fail. The new result seems to have the correct layout. That is a result of
recalcStyle() now being called from Frame::write(), where previously it wasn't
called since the decoder returned an empty string. When that happened, the
decoder was finally flushed in Frame::endIfNotLoading(), which didn't call
recalcStyle().

There are still cases where the decoder returns just an empty string to
write(), namely when the text is 16 bytes or shorter. Open these two URLs in
separate tabs and compare:
data:text/plain,abcdefghijklmnop
data:text/plain,abcdefghijklmnopq

I don't understand the role of the recalcStyle() call in write() (in
particular, whether it was intended only for the visually ordered case), so I
don't know if adding it in the corresponding places in endIfNotLoading() and in
write(const DeprecatedString& str) is the correct fix.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.