[Webkit-unassigned] [Bug 10490] remove broken SVGAnimated* code

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=10490





------- Comment #12 from zimmermann at kde.org  2006-09-04 05:46 PDT -------
Heya(In reply to comment #11)
> ANIMATED_PROPERTY_DEFINITIONS can probably be templatized too. Also, the
> reinterpret_cast in there is very likely unsafe.
> 

Heya Eric/Maciej,

I've worked quite a lot on this patch - now it actually works.

What did I change? :
* Removed the reinterpret_cast, and offer two macros
   ANIMATED_PROPERTY_OFFERS_CONTEXT / ANIMATED_PROPERTY_NEEDS_CONTEXT

  Classes which don't inherit from SVGElement themselves, but still store
animated
  properties need a way to access the SVGDocumentExtensions. Using these macros
  in ie. SVGURIReference it just says NEEDS_CONTEXT, which will evaluate to a
pure
  virtual function. All top-base classes specify OFFERS_CONTEXT. This way the
access
  to the SVG document extensions will work w/o any ugly casts.

  I adjusted the Ruby script to generate these OFFERS/NEEDED macros in the
right places.

* After running the script the default value initialization had to be fixed
(manually :( )
   I went through all classes where the lazy_creates have been removed from,
and
   moved the initialization directly into the constructor.

This makes the whole thing work, and the regression tests pass w/o any
intrduced problem!
Because it's very hard to split these patches up into parts (as I fiddled
around _after_ the
script has been run), I will just post a big 280k patch. Eric has already seen
the relevant things
in the patch. Happy reviewing! :-)


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.