[Webkit-unassigned] [Bug 11346] _blank is assigned to Window name

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 31 10:07:40 PST 2006


mjs at apple.com changed:

           What    |Removed                     |Added
  Attachment #11202|review?                     |review-
               Flag|                            |

------- Comment #8 from mjs at apple.com  2006-10-31 10:07 PDT -------
(From update of attachment 11202)
My comments:

1) This patch appears to be in RTF format, it needs to be in plain text.

2) There is no ChangeLog entry.

3) There is no test case in the patch - this probably can't be tested
automatically but it should include a test for the manual-tests directory.

4) This fix is at the wrong layer. There are ther constructs besides
window.open that can open a new window, such as <a href="http://somesite.com/"
target="_blank">, these need to be covered as well. The right place to fix this
is in the Frame code itself - a request to open a new window for _blank should
make sure that the name ends up empt instead of "_blank".

5) Comments in the code should not talk about making a specific fix, nor should
they describe what the code is doing if that is obvious just from reading.

6) Coding style issue, there should be a space between the "if" and the open
paren: if(frameName == "_blank")

Please addresse these issues and resubmit.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list