[Webkit-unassigned] [Bug 11433] Fixes to get WebKit to run on windows

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=11433


mjs at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11242|review?                     |review-
               Flag|                            |




------- Comment #3 from mjs at apple.com  2006-10-31 04:12 PDT -------
(From update of attachment 11242)
Thanks for hte patch!

Mostly this looks good. However, the implementation of mapRect is not correct.
Mapping a rect is not equivalent to mapping a point and a distance. Consider
the case of a rotated rect. In that case, you need to get the final bounding
box accounting for rotation. This is what the CG and Qt implementatios will do.

Also, the patch should include a ChangeLog entry.

Please address these issues and resubmit.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.