[Webkit-unassigned] [Bug 11423] REGRESSION: First newline missing from textarea's value

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=11423





------- Comment #9 from ddkilzer at kilzer.net  2006-10-27 14:21 PDT -------
(From update of attachment 11231)
>Index: WebCore/ChangeLog
>===================================================================
>--- WebCore/ChangeLog	(revision 17351)
>+++ WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,40 @@
>+2006-10-26  Justin Garcia  <justin.garcia at apple.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+        
>+        <http://bugs.webkit.org/show_bug.cgi?id=11423>
>+        REGRESSION: First newline missing from textarea's value
>+        
>+        The regression is that foo, return, bar in a textarea serializes as 'foobar'.
>+        
>+        Before my change in r11423, return (an InsertLineBreak) would insert '\n' (the
>+        line break) then a br to prevent a collapse, since the insertion is being done
>+        at the end of a block (the textarea's shadow div).  Then, inserting "bar" would 
>+        displace the br, and "foo\nbar" would serialize as "foo\nbar".  After my change 
>+        in r11423, InsertLineBreak would insert a br then a '\n' (reversed the order).  
>+        Then inserting "bar" would displace the '\n' and "foo"<br>"bar" would serialize as 
>+        "foobar" because when serializing RenderTextControl intentionally asks textContent 
>+        to not convert brs to newlines.  It seems to think that the only brs in the shadow
>+        div will be placeholders.

Justin, don't you mean "r17223" (per Comment #5) above instead of "r11423"?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.