[Webkit-unassigned] [Bug 7445] REGRESSION: Gmail puts wrong subject in replies

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=7445





------- Comment #12 from wac at google.com  2006-10-26 13:25 PDT -------
Created an attachment (id=11228)
 --> (http://bugs.webkit.org/attachment.cgi?id=11228&action=view)
Proposed patch for this bug

I strongly suspect this bug is an affect of the issue in 7253. Namely that
inline regexes (like /\u2620/i) match nothing (not even "\\u2620") while
explicitly created regexes (like new RegExp("\u2620","i")) will match the
"skull and crossbones" character.

I have a patch put together that corrects for this bug (see attachment). I've
run the patch through the JavaScriptCore tests and used (slightly modified)
Wesley's reduction in testkjs to make sure it corrects the behavior for this
case.

There is a new failure in the kjs tests as a result of the patch:
ecma_2/RegExp/properties-001.js
--> /\Q1/im.source = \Q1 FAILED! expected: \u0051
--> /\Q1/im.toString() = /\Q1/im FAILED! expected: /\u0051/im

I believe this is more a sign that RegExp objects need to be unicode escaping
their output than the patch is doing the wrong thing. But I also haven't looked
at the specification to see exactly what should/shouldn't be returned for
.source and .toString(), so I could be wrong about that.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.