[Webkit-unassigned] [Bug 11413] New: REGRESSION (r17280): Assertion failure in -[WebHTMLView(WebInternal) _delegateDragSourceActionMask] (_private->mouseDownEvent != nil) when clicking selected text

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=11413

           Summary: REGRESSION (r17280): Assertion failure in -
                    [WebHTMLView(WebInternal) _delegateDragSourceActionMask]
                    (_private->mouseDownEvent != nil) when clicking selected
                    text
           Product: WebKit
           Version: 420+ (nightly)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Keywords: Regression
          Severity: Major
          Priority: P1
         Component: New Bugs
        AssignedTo: webkit-unassigned at opendarwin.org
        ReportedBy: mitz at webkit.org
                CC: darin at apple.com


Backtrace:
0   com.apple.WebKit            0x01070258 -[WebHTMLView(WebInternal)
_delegateDragSourceActionMask] + 96 (WebHTMLView.m:4999)
1   com.apple.WebKit            0x0103c904 -[WebFrameBridge
allowDHTMLDrag:UADrag:] + 292 (WebFrameBridge.mm:966)
2   com.apple.WebCore           0x021b36a4
WebCore::FrameMac::eventMayStartDrag(NSEvent*) const + 212 (FrameMac.mm:1569)
3   com.apple.WebKit            0x01064c30 -[WebHTMLView
shouldDelayWindowOrderingForEvent:] + 348 (WebHTMLView.m:2846)
4   com.apple.AppKit            0x93766d08 -[NSWindow sendEvent:] + 1664
5   com.apple.Safari            0x00021734 0x1000 + 132916
6   com.apple.AppKit            0x937108d4 -[NSApplication sendEvent:] + 4172
7   com.apple.Safari            0x00021238 0x1000 + 131640
8   com.apple.AppKit            0x93707d10 -[NSApplication run] + 508
9   com.apple.AppKit            0x937f887c NSApplicationMain + 452
10  com.apple.Safari            0x0005c77c 0x1000 + 374652
11  com.apple.Safari            0x0005c624 0x1000 + 374308

The direct cause is probably this change to shouldDelayWindowOrderingForEvent:
in r17280:
     WebHTMLView *hitHTMLView = [hitView isKindOfClass:[self class]] ?
(WebHTMLView *)hitView : nil;
     if (hitHTMLView != nil) {
-        [hitHTMLView _setMouseDownEvent:event];
-        BOOL result = [hitHTMLView _isSelectionEvent:event] ? [[hitHTMLView
_bridge] eventMayStartDrag:event] : NO;
+        bool result = false;
+        if ([hitHTMLView _isSelectionEvent:event])
+            if (FrameMac* frame = [[hitHTMLView _bridge] _frame])
+                result = frame->eventMayStartDrag(event);
         [hitHTMLView _setMouseDownEvent:nil];
         return result;


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.