[Webkit-unassigned] [Bug 11108] Replace usage of split by proper parsers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 20 13:47:07 PDT 2006


http://bugs.webkit.org/show_bug.cgi?id=11108


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10944|review?                     |review-
               Flag|                            |




------- Comment #12 from mitz at webkit.org  2006-10-20 13:47 PDT -------
(From update of attachment 10944)
Additional observations:

In SVGColor::setRGBColor(), normal == 3 - percentages, so you don't need two
variables.

Brace should be indented:
+    static inline bool skipOptionalSpaces(const UChar*& ptr) // true means
"found space"
+{

Brace should be on the switch line:
+        switch (type)
+        {


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list