[Webkit-unassigned] [Bug 11367] Inline Breakpoint Editor Improvements: Act III

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 20 09:27:38 PDT 2006


timothy at hatcher.name changed:

           What    |Removed                     |Added
  Attachment #11162|review?                     |review-
               Flag|                            |

------- Comment #3 from timothy at hatcher.name  2006-10-20 09:27 PDT -------
(From update of attachment 11162)
Looks good.

Some comments:

Make the bullets in the ChangeLog asterisks.

Remove the white background and border on the .hitCounter.

Make sure you didn't break the console history now that we can log msgs without
expressions. IIRC the history relied on childNode indices.

+    while(!node.hasStyleClass(className))
+    {

Our style puts the { on the same line as while.

+        if(node == document) return null;

Our style puts the "return null;" on the next line. Also a space after the if.

The same same firstParentWithClass code in viewer.html.

new Function("toggleBreakpointEditorOnLine(parseInt(event.target.title));")

This can be written as:

function () { toggleBreakpointEditorOnLine(parseInt(event.target.title)); }

+    if(breakpoint && breakpoint.enabled) {
+                if(shouldBreak)
+                if(breakpoint.value != "break")
+                if(consoleWindow)
+        if(editor)
+        if(counter)

Add a space after the if.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list