[Webkit-unassigned] [Bug 11332] SVG support for Linux port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 17 21:22:25 PDT 2006


------- Comment #5 from bdash at webkit.org  2006-10-17 21:22 PDT -------
AffineTransform has lots of commented out code in it.  Your second patch has
changes to the header -- did you intend to include changes to the
implementation too?

In GraphicsContextCairo::pathDebugString, and other places, you have
inconsistent use of spaces around assignments.  You also have the ()'s placed
incorrectly next to if's in that function, and others.

You have braces around a single-line if inside Path::operator=. 
Path::strokeBoundingRect appears to have incorrect indentation, and incorrect
spacing in the "if" statement.

The Page constructor in PageGdk.cpp has its member initialization incorrectly
laid out.  Page::windowRect has incorrect spacing around if statements.

I could easily go on, but as you say it is a lot of code.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list