[Webkit-unassigned] [Bug 11217] Cleanup svg coding style

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 14 14:32:27 PDT 2006


mitz at webkit.org changed:

           What    |Removed                     |Added
  Attachment #11089|review?                     |review-
               Flag|                            |

------- Comment #31 from mitz at webkit.org  2006-10-14 14:32 PDT -------
(From update of attachment 11089)
My only comments are about lines that the patch doesn't touch:

The opening brace should go on the same line as the case:

         case SVG_LENGTHTYPE_EXS:

This needs spaces after the semicolons:

     for (unsigned long i = 0;i < list->numberOfItems();i++) {

The way this is split into lines doesn't make sense. I think two lines with 4
parameters in each will suffice, but otherwise, it should be 2 parameters on
each line:
+        SVGMatrix* getCTM(float logicX, float logicY,
                               float logicWidth, float logicHeight,
                               float physX, float physY, float physWidth,
                               float physHeight);

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list