[Webkit-unassigned] [Bug 11217] Cleanup svg coding style

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 13 12:53:18 PDT 2006


http://bugs.webkit.org/show_bug.cgi?id=11217


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11073|review?                     |review-
               Flag|                            |




------- Comment #27 from mitz at webkit.org  2006-10-13 12:53 PDT -------
(From update of attachment 11073)
Redundant parameter names (some of these show up multiple times):

-        virtual void buildGradient(KRenderingPaintServerGradient *grad) const
= 0;
+        virtual void buildGradient(KRenderingPaintServerGradient* grad) const
= 0;

-        const SVGStyledElement *pushAttributeContext(const SVGStyledElement
*context);
+        const SVGStyledElement* pushAttributeContext(const SVGStyledElement*
context);

-        virtual void buildGradient(KRenderingPaintServerGradient *grad) const;
+        virtual void buildGradient(KRenderingPaintServerGradient* grad) const;

Don't need the "!= 0" here:

+    for (Node* n = target->firstChild(); n != 0; n = n->nextSibling()) {

Don't need the space before the > here (some of these show up multiple times):

         SVGStyledElement* e = static_cast<SVGStyledElement* >(elem);

         SVGStyledElement* styled = (current ? static_cast<SVGStyledElement*
>(current->element()) : 0);

         m_paintServer->setListener(const_cast<SVGPatternElement* >(this));

-    KRenderingPaintServerRadialGradient *grad =
static_cast<KRenderingPaintServerRadialGradient *>(_grad);
+    KRenderingPaintServerRadialGradient* grad =
static_cast<KRenderingPaintServerRadialGradient* >(_grad);

-        KRenderingPaintServerGradient *gradient =
static_cast<KRenderingPaintServerGradient *>(pserver);
+        KRenderingPaintServerGradient* gradient =
static_cast<KRenderingPaintServerGradient* >(pserver);

+            KRenderingPaintServerRadialGradient* radial =
static_cast<KRenderingPaintServerRadialGradient* >(pserver);


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list