[Webkit-unassigned] [Bug 11217] Cleanup svg coding style

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 13 00:56:34 PDT 2006


mitz at webkit.org changed:

           What    |Removed                     |Added
  Attachment #11052|review?                     |review-
               Flag|                            |

------- Comment #21 from mitz at webkit.org  2006-10-13 00:56 PDT -------
(From update of attachment 11052)
Unnecessary parameter names in
+        SVGDocument(DOMImplementation* i, FrameView* view);

These should be two lines each:
+    if (SVGLangSpace::parseMappedAttribute(attr)) return;
+    if (SVGExternalResourcesRequired::parseMappedAttribute(attr)) return;
+    if (SVGFitToViewBox::parseMappedAttribute(attr)) return;

I also discussed with Rob the commented-out code in SVGSVGElement.cpp. Those
comments should be deleted and replaced with FIXMEs, preferably referring to
bugs about the missing functionality.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list